Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(primitives): consolidated isValidHex usage #2031

Closed
wants to merge 4 commits into from

Merge branch 'main' into consilidate-isValidHex

9710e4d
Select commit
Loading
Failed to load commit list.
Closed

chore(primitives): consolidated isValidHex usage #2031

Merge branch 'main' into consilidate-isValidHex
9710e4d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 1s

22.42% (target 0.00%)

View this Pull Request on Codecov

22.42% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.42%. Comparing base (5bdacfc) to head (9710e4d).

Files with missing lines Patch % Lines
mod/primitives/pkg/encoding/hex/format.go 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
- Coverage   22.42%   22.42%   -0.01%     
==========================================
  Files         358      358              
  Lines       16012    16007       -5     
  Branches       12       12              
==========================================
- Hits         3591     3589       -2     
+ Misses      12272    12271       -1     
+ Partials      149      147       -2     
Files with missing lines Coverage Δ
mod/primitives/pkg/encoding/hex/string.go 83.49% <100.00%> (-0.47%) ⬇️
mod/primitives/pkg/encoding/hex/format.go 65.95% <69.23%> (+4.73%) ⬆️