Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(state-processor): update validators EffectiveBalance only when epoch turns #2142

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
+574 −209

Merge branch 'main' into complete-validator-set-updates

e72fe31
Select commit
Loading
Failed to load commit list.
Open

feature(state-processor): update validators EffectiveBalance only when epoch turns #2142

Merge branch 'main' into complete-validator-set-updates
e72fe31
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 14, 2024 in 0s

26.51% (target 0.00%)

View this Pull Request on Codecov

26.51% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 61.29032% with 48 lines in your changes missing coverage. Please review.

Project coverage is 26.51%. Comparing base (8a04173) to head (e72fe31).

Files with missing lines Patch % Lines
mod/state-transition/pkg/core/state_processor.go 54.71% 16 Missing and 8 partials ⚠️
...ate-transition/pkg/core/state_processor_genesis.go 65.78% 2 Missing and 11 partials ⚠️
mod/chain-spec/pkg/chain/chain_spec.go 0.00% 6 Missing ⚠️
...ate-transition/pkg/core/state_processor_staking.go 64.28% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2142      +/-   ##
==========================================
+ Coverage   26.28%   26.51%   +0.22%     
==========================================
  Files         360      360              
  Lines       16243    16244       +1     
  Branches       12       12              
==========================================
+ Hits         4270     4307      +37     
+ Misses      11705    11658      -47     
- Partials      268      279      +11
Files with missing lines Coverage Δ
mod/config/pkg/spec/testnet.go 100.00% <100.00%> (ø)
...e-transition/pkg/core/state_processor_committee.go 84.21% <100.00%> (+5.63%) ⬆️
...ate-transition/pkg/core/state_processor_staking.go 54.21% <64.28%> (-0.58%) ⬇️
mod/chain-spec/pkg/chain/chain_spec.go 11.90% <0.00%> (-0.92%) ⬇️
...ate-transition/pkg/core/state_processor_genesis.go 49.39% <65.78%> (-0.61%) ⬇️
mod/state-transition/pkg/core/state_processor.go 35.27% <54.71%> (+8.57%) ⬆️

... and 3 files with indirect coverage changes

View more details on Codecov