-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: readme #2157
base: main
Are you sure you want to change the base?
docs: readme #2157
Conversation
Signed-off-by: Olexandr88 <radole1203@gmail.com>
WalkthroughThe changes in this pull request focus on updating the Telegram chat link in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -17,7 +17,7 @@ _The project is still heavily under construction, see the [disclaimer below](#st | |||
|
|||
[![CI status](https://github.com/berachain/beacon-kit/workflows/pipeline/badge.svg)](https://github.com/berachain/beacon-kit/actions/workflows/pipeline.yml) | |||
[![CodeCov](https://codecov.io/gh/berachain/beacon-kit/graph/badge.svg?token=0l5iJ3ZbzV)](https://codecov.io/gh/berachain/beacon-kit) | |||
[![Telegram Chat](https://img.shields.io/endpoint?color=neon&logo=telegram&label=chat&url=https%3A%2F%2Ftg.sumanjay.workers.dev%2Fbeacon_kit)](https://t.me/beacon_kit) | |||
[![Telegram Chat](https://img.shields.io/endpoint?color=neon&logo=telegram&label=chat&url=https%3A%2F%2Ftg.sumanjay.workers.dev%2Fbeacon_kit)](https://t.me/BerachainPortal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Inconsistency detected in Telegram badge configuration
The search results reveal a mismatch between the badge configuration and the actual link:
- The badge URL still points to
beacon_kit
(tg.sumanjay.workers.dev/beacon_kit
) - But the clickable link redirects to
BerachainPortal
(t.me/BerachainPortal
)
This inconsistency should be fixed by updating both URLs to use BerachainPortal
.
🔗 Analysis chain
Verify the new Telegram link and its consistency
The link update from beacon_kit
to BerachainPortal
appears to align with the main site. Let's verify the links and consistency.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify Telegram links and consistency across the codebase
# Check if there are any other references to the old Telegram link
echo "Checking for other occurrences of the old Telegram link..."
rg -i "beacon_kit" --type md
# Check if there are any existing references to the new Telegram link
echo "Checking for existing references to the new Telegram link..."
rg -i "BerachainPortal" --type md
# Check if the README mentions the Telegram link anywhere else
echo "Checking for other Telegram references in README..."
rg -i "telegram" README.md
# Look for any documentation files that might need updates
echo "Checking for documentation files that might need updates..."
fd -e md -e mdx
Length of output: 1390
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even the Beacon-kit main site links to this link
Could you pls elaborate this. Are you referring to Berachain website here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the same TG group. What's the motivation here?
In my opinion, the new link will be considered more correct. Even the Beacon-kit main site links to this link
Summary by CodeRabbit