Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(withdrawals): Fixed withdrawal for EVM inflation per block #2158
base: main
Are you sure you want to change the base?
feat(withdrawals): Fixed withdrawal for EVM inflation per block #2158
Changes from 17 commits
d9f823a
c0a78e4
0ad6329
fb1177c
6c91765
270b6ae
ddb711e
d898aef
afea1e7
3c11427
ff487e9
220f499
a2849f2
27f74ce
a1cf677
fdb5163
6a3f282
6fd0c0a
c68fcab
5517eb9
4f221e9
c498b53
45502d5
b60f6cd
2e96a53
13631c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rabbit is right, should we at least validate inflation parameters?
ExecutionAddressT
its own validationEVMInflationPerBlock
ever be zero?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both of these can be the 0 values, no other validation needed. (InflationAddress can be the zero address, Inflation per block can be 0)