Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncap Cabal release dependency #9

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

Vekhir
Copy link
Contributor

@Vekhir Vekhir commented Sep 5, 2023

Hi,
for unrelated reasons, I had to use Cabal 3.6.3 which doesn't work with uusi, so this PR seeks to remedy that.

With this change, all cabal versions since 3.2 are allowed, with the exception of 3.6.0/1/2 due to breaking changes.
A change in Cabal 3.6.3 (contained in GHC 9.2.8) makes that version the only allowed release in that series. This is essentially a continuation of the last commit, but with tighter bounds around the offending issue. The previous attempt was narrowly focused on solving it for GHC 9.6. This change is tested with all recent GHC releases and Cabal releases, though 3.6.3 is not available via ghcup. It should work for future compiler releases too.

Oh, and please make a release to hackage, so these latest changes can be built into a regular Arch package. I'd be very grateful for that!

-- Vekhir

A change in Cabal 3.6.3 (contained in GHC 9.2.8) makes that version the only
allowed release in that series.
Otherwise uncap the dependency on Cabal, so future compiler releases (like 9.8)
don't require unnecessary version bumps.
@Vekhir
Copy link
Contributor Author

Vekhir commented Sep 6, 2023

@berberman Oh, forgot to tag you. This PR is the continuation of the last one, fixing the issue for all compilers starting at 9.2.8. Hopefully, no changes will be necessary for 9.8 :)

uusi.cabal Outdated Show resolved Hide resolved
@berberman berberman merged commit 1dd3e62 into berberman:master Sep 8, 2023
24 checks passed
@berberman
Copy link
Owner

Thank you! Just made a hackage release: https://hackage.haskell.org/package/uusi-0.4.3.0

@Vekhir
Copy link
Contributor Author

Vekhir commented Sep 8, 2023

@berberman Thank you for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants