Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: strip whitespaces in BaseProcessor #34

Open
LerikP opened this issue Sep 4, 2020 · 0 comments
Open

Feature request: strip whitespaces in BaseProcessor #34

LerikP opened this issue Sep 4, 2020 · 0 comments

Comments

@LerikP
Copy link
Contributor

LerikP commented Sep 4, 2020

Proposition:
I propose to strip whitespaces in BaseProcessor and assume whitespaced values as None.

Reason:
Cells with whitespaces in large files are hard to find for users and displayed error is not clear to them.

Expected behavior:

def test_integer_processor_with_whitespace():
    processor = IntegerProcessor()

    assert processor(' ') is None

Current result:

import_me.exceptions.ColumnError:   is not an integer.
LerikP added a commit to LerikP/import_me that referenced this issue Sep 4, 2020
yakovistomin added a commit that referenced this issue Nov 24, 2020
Strip whitespaces in BaseProcessor. Issue #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant