Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hidden debug #3530

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix hidden debug #3530

merged 2 commits into from
Aug 1, 2023

Conversation

haslinghuis
Copy link
Member

@ctzsnooze was missing some debugs in sensors tab.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jul 28, 2023
@haslinghuis haslinghuis self-assigned this Jul 28, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Jul 28, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ctzsnooze
Copy link
Member

Thanks, @haslinghuis - now the debug traces in Sensors tab show static values as well as changing values. Very useful if, for instance, we just debug a fixed number, or the number doesn't change until some time passes. Very grateful.

@nerdCopter
Copy link
Member

approved untested; visual inspection only.

@haslinghuis haslinghuis merged commit 92a8748 into betaflight:master Aug 1, 2023
9 checks passed
@haslinghuis haslinghuis deleted the fix-hidden-debug branch August 1, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
Cleanup Ready to Merge
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @ctzsnooze @nerdCopter