Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed accel scaling in motors tab #3547

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fixed accel scaling in motors tab #3547

merged 1 commit into from
Dec 4, 2023

Conversation

flaviopinzarrone
Copy link
Contributor

@flaviopinzarrone flaviopinzarrone commented Aug 15, 2023 •
edited
Loading

Refers to PR #13026 in betaflight repo.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flaviopinzarrone flaviopinzarrone mentioned this pull request Aug 15, 2023
Merged
@blckmn
Copy link
Member

blckmn commented Aug 15, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.10.0 milestone Aug 15, 2023
@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

please check sensors tab as well

@nerdCopter
Copy link
Member

needs to be somewhat backward compatible.

asizon
asizon previously approved these changes Aug 17, 2023
View reviewed changes
@asizon asizon dismissed their stale review August 17, 2023 09:25

Waiting to firmware side discussion

@nerdCopter
Copy link
Member

4.4.3
2023-12-04_10-51_4 4 3

4.5 with said code
2023-12-04_10-53_4 5

@haslinghuis haslinghuis merged commit 22a2eee into betaflight:master Dec 4, 2023
8 checks passed
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@flaviopinzarrone @chmelevskij
fixed accel scaling in motors tab (betaflight#3547)
f3b8402 
fixed accel scaling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon asizon left review comments

Assignees

@flaviopinzarrone flaviopinzarrone

Labels
Needs coordination with firmware RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@flaviopinzarrone @blckmn @nerdCopter @haslinghuis @asizon