Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add LED strip sliders" #3548

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Revert "Add LED strip sliders" #3548

merged 1 commit into from
Aug 18, 2023

Conversation

haslinghuis
Copy link
Member

Reverts #3531

Firmware PR is not merget yet and involves MSP changes possible corrupting configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Aug 18, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@asizon asizon merged commit 19d12b5 into master Aug 18, 2023
8 checks passed
@haslinghuis haslinghuis deleted the revert-3531-slider branch August 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitroidFPV VitroidFPV VitroidFPV approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@asizon asizon asizon approved these changes

@blckmn blckmn Awaiting requested review from blckmn

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees
No one assigned
Labels
Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @asizon @nerdCopter @VitroidFPV