Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buildkey 404 #3899

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Fix buildkey 404 #3899

merged 1 commit into from
Apr 20, 2024

Conversation

haslinghuis
Copy link
Member

  • cachedData does not work for retrieving build key options when server returns 404.

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 19, 2024
@haslinghuis haslinghuis self-assigned this Apr 19, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 19, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 1807dbe
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6622deb8d75e7c0008475a1d
😎 Deploy Preview https://deploy-preview-3899--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@nerdCopter
Copy link
Member

e2b1bda6
fake buildkey:
make FOXEERF405 EXTRA_FLAGS="-D'BUILD_KEY=46f7acaa85e6eb03b862d31c4f000000' -D'RELEASE_NAME=4.5.0-dev' -DCLOUD_BUILD -DUSE_CAMERA_CONTROL -DUSE_DSHOT -DUSE_EMFAT_AUTORUN -DUSE_EMFAT_ICON -DUSE_EMFAT_TOOLS -DUSE_GPS -DUSE_GPS_PLUS_CODES -DUSE_LED_STRIP -DUSE_OSD -DUSE_OSD_SD -DUSE_PINIO -DUSE_SERIALRX -DUSE_SERIALRX_CRSF -DUSE_TELEMETRY -DUSE_TELEMETRY_CRSF -DUSE_VTX"
image

Console Log

image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis
Copy link
Member Author

@nerdCopter

  • Setup tab just links to the online URL - not using buildAPI
  • This PR only fixes the issue on firmware flasher tab

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

1807dbe4
okay, the 404 seem to be "caught".
image

@haslinghuis haslinghuis merged commit 4af5757 into betaflight:master Apr 20, 2024
12 checks passed
@haslinghuis haslinghuis deleted the fix-invalid-key branch April 20, 2024 21:18
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix buildkey 404 (betaflight#3899)
3190435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@blckmn blckmn blckmn approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @nerdCopter @blckmn