-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dual telemetry in receiver tab for local builds #3923
Conversation
haslinghuis
commented
Apr 29, 2024
- Fixes Telemetry slider appears twice #3920
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment has been minimized.
This comment has been minimized.
The feature is already present in the list, and then some code which looks at I'm not sure why the code in Features exists (the bit that does |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Do you want to test this code? Here you have an automated build: |
In 4.4 we used build API to retrieve build information to retrieve options included As for 4.5 the telemetry options are not available in firmware so have added them afterwards in software to display telemetry in receiver tab. |
Thanks for the info. I'll leave the fix up to you guys, you should have all you need to replicate the issue and verify the fix, if not let me know. Please ping me if there's an updated fix for me to try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- approving untested as i cannot reproduce source issue.
Was able to reproduce with local build. |
thanks for the fix @haslinghuis |