Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dual telemetry in receiver tab for local builds #3923

Merged
merged 2 commits into from
May 2, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis added this to the 11.0 milestone Apr 29, 2024
@haslinghuis haslinghuis self-assigned this Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 796e770
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6630c7e10727030008b5facf
😎 Deploy Preview https://deploy-preview-3923--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This comment has been minimized.

@hydra
Copy link
Contributor

hydra commented Apr 30, 2024

Still broken:
image
image

Firmware built using:

make CONFIG=SPRACINGH7RF

@hydra
Copy link
Contributor

hydra commented Apr 30, 2024

Maybe this screenshot helps?

image

There's duplicate data in self._features at the time FC.FEATURE_CONFIG.features.generateElements(featuresElement); is called from recieiver.js

@hydra
Copy link
Contributor

hydra commented Apr 30, 2024

image

image

image

The feature is already present in the list, and then some code which looks at buildOptions (which I'm not familiar with) adds it again.

I'm not sure why the code in Features exists (the bit that does // Add TELEMETRY feature if any of the following protocols are used: CRSF, GHST, FPORT), perhaps you could shed some light on it? How is it possible to build firmware that doesn't include the feature bit? Surely that's the root cause of this and where the fix should be applied?

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member Author

@hydra

In 4.4 we used build API to retrieve build information to retrieve options included
In 4.5 we can retrieve them directly from firmware.

As for 4.5 the telemetry options are not available in firmware so have added them afterwards in software to display telemetry in receiver tab.

Details: betaflight/betaflight#13333 (comment)

@hydra
Copy link
Contributor

hydra commented Apr 30, 2024

@hydra
In 4.4 we used build API to retrieve build information to retrieve options included In 4.5 we can retrieve them directly from firmware.
As for 4.5 the telemetry options are not available in firmware so have added them afterwards in software to display telemetry in receiver tab.
Details: betaflight/betaflight#13333 (comment)

Thanks for the info.

I'll leave the fix up to you guys, you should have all you need to replicate the issue and verify the fix, if not let me know. Please ping me if there's an updated fix for me to try.

@haslinghuis haslinghuis changed the title Fix dual telemetry in receiver tab Fix dual telemetry in receiver tab for local builds Apr 30, 2024
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested as i cannot reproduce source issue.

@haslinghuis
Copy link
Member Author

Was able to reproduce with local build.

@haslinghuis haslinghuis merged commit 9e25c16 into betaflight:master May 2, 2024
11 of 12 checks passed
@haslinghuis haslinghuis deleted the fix-dual-telemetry branch May 2, 2024 16:14
@hydra
Copy link
Contributor

hydra commented May 6, 2024

thanks for the fix @haslinghuis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Telemetry slider appears twice
4 participants