-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style: UI Refresh #3956
Style: UI Refresh #3956
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment has been minimized.
This comment has been minimized.
Tested the mobile layout, and fixes the issue with the size. Thanks! |
@McGiverGim please comment as you wish 😅. For now, the Setup tab is the only one I tested across all sizes, the others not yet. I should have a couple done today, so I'll push them up |
save/reboot/etc is always left-aligned. edit: yellow/orange links/words over white/gray is difficult on the eyes. |
40516dd
to
244d14f
Compare
@McGiverGim I was mostly working in dark mode, I'll fix the contrast issues, that does look pretty bad! As for the layout, for now, I wanted to make the big changes first and address the smaller alignments afterward when I can be sure it won't break some other thing |
I understand. It's s lot of work. Thanks for moving into this! |
58d2f68
to
7a1b0e6
Compare
One thing: please, don't forget the Radio Emulator for MSP. It's usually forgotten and now the style is broken in this PR. |
Quality Gate passedIssues Measures |
I agree, I'll merge this while there are no other conflicts |
This PR aims to:
Screenshots below:
Or use preview deploy in the comments.
Opening the PR with the Setup tab being converted to the new layout and different breakpoints for desktop, tablet and mobile as I work on the rest. More tabs will be converted and old styles will be removed/updated going forward.
Please leave lots of constructive feedback! This is a big change, but it was discussed a lot internally prior to the PR - we belive this is a good way forward