Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Rates do not update after rateprofile switch #236

Open
ianrmurphy opened this issue Jul 22, 2018 · 9 comments
Open

RC Rates do not update after rateprofile switch #236

ianrmurphy opened this issue Jul 22, 2018 · 9 comments
Labels

Comments

@ianrmurphy
Copy link
Contributor

When switching rate values using rateprofile mapped to an Aux switch, the RC Rates graphs do not update to show the correct values for the new rates.
RC Rates appear to be calculated internal to blackbox-log-viewer (flightlog.js/calculateSetpointRate()) from the header data, which is not refreshed upon the rateprofile change. Only an event marker is inserted.
This is likely known behaviour but I could not find any reference to it in previous issues or other documentation.

@McGiverGim
Copy link
Member

Yes. It is calculated at the beginning ignoring rate changes. Attach a log and I will try to check it when I have time.

@ianrmurphy
Copy link
Contributor Author

Will do, I need to take a log with stock 3.4.0 firmware as I'm currently flying versions related to betaflight/betaflight#6402 that won't show correct behaviour (or reproduce the issue accurately) unless viewed with #237 .

@stale
Copy link

stale bot commented Aug 21, 2018

This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@stale stale bot added the Inactive label Aug 21, 2018
@stale
Copy link

stale bot commented Aug 28, 2018

Automatically closing as inactive.

@stale stale bot closed this as completed Aug 28, 2018
@ctzsnooze
Copy link
Member

Here's an example, rates were changed twice, we can see the RC Rate calculation not changing after the rate profile change in the log.
YawTesting.BBL.zip

@McGiverGim McGiverGim reopened this Sep 4, 2018
@stale stale bot removed the Inactive label Sep 4, 2018
@ctzsnooze
Copy link
Member

ctzsnooze commented Sep 4, 2018

rate profile change
that's the first rate profile change, where set rate was changed from 720 to 920 - looks like I suddenly was overshooting the target ! :-)

@stale
Copy link

stale bot commented Oct 4, 2018

This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@stale stale bot added the Inactive label Oct 4, 2018
@stale
Copy link

stale bot commented Oct 11, 2018

Automatically closing as inactive.

@stale stale bot closed this as completed Oct 11, 2018
@McGiverGim
Copy link
Member

I reopen this. I had no time to look into it but perhaps...

@McGiverGim McGiverGim reopened this Oct 11, 2018
@stale stale bot removed the Inactive label Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants