CI fixes

bevyengine · Jan 6, 2024 · 2f55e90 · 2f55e90
1 parent 66e11fe
commit 2f55e90
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/crates/bevy_pbr/Cargo.toml b/crates/bevy_pbr/Cargo.toml
@@ -31,7 +31,7 @@ bevy_window = { path = "../bevy_window", version = "0.12.0" }
 bevy_derive = { path = "../bevy_derive", version = "0.12.0" }
 
 # other
-meshopt = { git = "https://github.com/JMS55/meshopt-rs", optional = true}
+meshopt = { git = "https://github.com/JMS55/meshopt-rs", optional = true }
 rayon = { version = "1", optional = true }
 bitflags = "2.3"
 fixedbitset = "0.4"

diff --git a/crates/bevy_pbr/src/meshlet/from_mesh.rs b/crates/bevy_pbr/src/meshlet/from_mesh.rs
@@ -19,7 +19,7 @@ impl MeshletMesh {
     /// The input mesh must:
     /// 1. Use [`PrimitiveTopology::TriangleList`]
     /// 2. Use indices
-    /// 3. Have the exact following set of vertex attributes: {POSITION, NORMAL, UV_0, TANGENT}
+    /// 3. Have the exact following set of vertex attributes: `{POSITION, NORMAL, UV_0, TANGENT}`
     pub fn from_mesh(mesh: &Mesh) -> Result<Self, MeshToMeshletMeshConversionError> {
         if mesh.primitive_topology() != PrimitiveTopology::TriangleList {
             return Err(MeshToMeshletMeshConversionError::WrongMeshPrimitiveTopology);

diff --git a/crates/bevy_pbr/src/meshlet/mod.rs b/crates/bevy_pbr/src/meshlet/mod.rs
@@ -78,7 +78,7 @@ const MESHLET_MESH_MATERIAL_SHADER_HANDLE: Handle<Shader> =
 ///
 /// This plugin is not compatible with [`Msaa`], and adding this plugin will disable it.
 ///
-/// ![A render of the Stanford dragon as a MeshletMesh](https://github.com/bevyengine/bevy/blob/main/crates/bevy_pbr/src/meshlet/meshlet_preview.png),
+/// ![A render of the Stanford dragon as a `MeshletMesh`](https://github.com/bevyengine/bevy/blob/main/crates/bevy_pbr/src/meshlet/meshlet_preview.png),
 pub struct MeshletPlugin;
 
 impl Plugin for MeshletPlugin {

diff --git a/docs/cargo_features.md b/docs/cargo_features.md
@@ -59,6 +59,7 @@ The default feature set enables most of the expected features of a game engine,
 |flac|FLAC audio format support|
 |glam_assert|Enable assertions to check the validity of parameters passed to glam|
 |jpeg|JPEG image format support|
+|meshopt|Enables processing meshes into meshlet meshes for bevy_pbr|
 |minimp3|MP3 audio format support (through minimp3)|
 |mp3|MP3 audio format support|
 |pbr_transmission_textures|Enable support for transmission-related textures in the `StandardMaterial`, at the risk of blowing past the global, per-shader texture limit on older/lower-end GPUs|