Cosmic text

Cargo.toml

@@ -268,9 +268,6 @@ wayland = ["bevy_internal/wayland"]
 # X11 display server support
 x11 = ["bevy_internal/x11"]
 
-# Enable rendering of font glyphs using subpixel accuracy
-subpixel_glyph_atlas = ["bevy_internal/subpixel_glyph_atlas"]
-
 # Enable systems that allow for automated testing on CI
 bevy_ci_testing = ["bevy_internal/bevy_ci_testing"]
 

crates/bevy_internal/Cargo.toml

@@ -93,9 +93,6 @@ async-io = ["bevy_tasks/async-io"]
 wayland = ["bevy_winit/wayland"]
 x11 = ["bevy_winit/x11"]
 
-# enable rendering of font glyphs using subpixel accuracy
-subpixel_glyph_atlas = ["bevy_text/subpixel_glyph_atlas"]
-
 # Transmission textures in `StandardMaterial`:
 pbr_transmission_textures = [
   "bevy_pbr?/pbr_transmission_textures",

crates/bevy_sprite/src/render/mod.rs

@@ -375,14 +375,15 @@ pub fn extract_sprites(
                     .map(|e| (commands.spawn_empty().id(), e)),
             );
         } else {
-            let atlas_rect = sheet.and_then(|s| s.texture_rect(&texture_atlases));
+            let atlas_rect =
+                sheet.and_then(|s| s.texture_rect(&texture_atlases).map(|r| r.as_rect()));
             let rect = match (atlas_rect, sprite.rect) {
                 (None, None) => None,
                 (None, Some(sprite_rect)) => Some(sprite_rect),
-                (Some(atlas_rect), None) => Some(atlas_rect.as_rect()),
+                (Some(atlas_rect), None) => Some(atlas_rect),
                 (Some(atlas_rect), Some(mut sprite_rect)) => {
-                    sprite_rect.min += atlas_rect.min.as_vec2();
-                    sprite_rect.max += atlas_rect.min.as_vec2();
+                    sprite_rect.min += atlas_rect.min;
+                    sprite_rect.max += atlas_rect.min;
 
                     Some(sprite_rect)
                 }

crates/bevy_sprite/src/texture_atlas.rs

@@ -31,26 +31,6 @@ pub struct TextureAtlasLayout {
     pub(crate) texture_handles: Option<HashMap<AssetId<Image>, usize>>,
 }
 
-/// Component used to draw a specific section of a texture.
-///
-/// It stores a handle to [`TextureAtlasLayout`] and the index of the current section of the atlas.
-/// The texture atlas contains various *sections* of a given texture, allowing users to have a single
-/// image file for either sprite animation or global mapping.
-/// You can change the texture [`index`](Self::index) of the atlas to animate the sprite or display only a *section* of the texture
-/// for efficient rendering of related game objects.
-///
-/// Check the following examples for usage:
-/// - [`animated sprite sheet example`](https://github.com/bevyengine/bevy/blob/latest/examples/2d/sprite_sheet.rs)
-/// - [`sprite animation event example`](https://github.com/bevyengine/bevy/blob/latest/examples/2d/sprite_animation.rs)
-/// - [`texture atlas example`](https://github.com/bevyengine/bevy/blob/latest/examples/2d/texture_atlas.rs)
-#[derive(Component, Default, Debug, Clone, Reflect)]
-pub struct TextureAtlas {
-    /// Texture atlas layout handle
-    pub layout: Handle<TextureAtlasLayout>,
-    /// Texture atlas section index
-    pub index: usize,
-}
-
 impl TextureAtlasLayout {
     /// Create a new empty layout with custom `dimensions`
     pub fn new_empty(dimensions: UVec2) -> Self {
@@ -149,6 +129,26 @@ impl TextureAtlasLayout {
     }
 }
 
+/// Component used to draw a specific section of a texture.
+///
+/// It stores a handle to [`TextureAtlasLayout`] and the index of the current section of the atlas.
+/// The texture atlas contains various *sections* of a given texture, allowing users to have a single
+/// image file for either sprite animation or global mapping.
+/// You can change the texture [`index`](Self::index) of the atlas to animate the sprite or display only a *section* of the texture
+/// for efficient rendering of related game objects.
+///
+/// Check the following examples for usage:
+/// - [`animated sprite sheet example`](https://github.com/bevyengine/bevy/blob/latest/examples/2d/sprite_sheet.rs)
+/// - [`sprite animation event example`](https://github.com/bevyengine/bevy/blob/latest/examples/2d/sprite_animation.rs)
+/// - [`texture atlas example`](https://github.com/bevyengine/bevy/blob/latest/examples/2d/texture_atlas.rs)
+#[derive(Component, Default, Debug, Clone, Reflect)]
+pub struct TextureAtlas {
+    /// Texture atlas layout handle
+    pub layout: Handle<TextureAtlasLayout>,
+    /// Texture atlas section index
+    pub index: usize,
+}
+
 impl TextureAtlas {
     /// Retrieves the current texture [`URect`] of the sprite sheet according to the section `index`
     pub fn texture_rect(&self, texture_atlases: &Assets<TextureAtlasLayout>) -> Option<URect> {

crates/bevy_text/Cargo.toml

@@ -9,14 +9,14 @@ license = "MIT OR Apache-2.0"
 keywords = ["bevy"]
 
 [features]
-subpixel_glyph_atlas = []
 default_font = []
 
 [dependencies]
 # bevy
 bevy_app = { path = "../bevy_app", version = "0.14.0-dev" }
 bevy_asset = { path = "../bevy_asset", version = "0.14.0-dev" }
 bevy_color = { path = "../bevy_color", version = "0.14.0-dev" }
+bevy_derive = { path = "../bevy_derive", version = "0.14.0-dev" }
 bevy_ecs = { path = "../bevy_ecs", version = "0.14.0-dev" }
 bevy_math = { path = "../bevy_math", version = "0.14.0-dev" }
 bevy_reflect = { path = "../bevy_reflect", version = "0.14.0-dev", features = [
@@ -29,10 +29,11 @@ bevy_window = { path = "../bevy_window", version = "0.14.0-dev" }
 bevy_utils = { path = "../bevy_utils", version = "0.14.0-dev" }
 
 # other
-ab_glyph = "0.2.6"
-glyph_brush_layout = "0.2.1"
+cosmic-text = "0.12"
 thiserror = "1.0"
 serde = { version = "1", features = ["derive"] }
+unicode-bidi = "0.3.13"
+sys-locale = "0.3.0"
 
 [dev-dependencies]
 approx = "0.5.1"

crates/bevy_text/src/error.rs

@@ -1,10 +1,17 @@
-use ab_glyph::GlyphId;
+use cosmic_text::CacheKey;
 use thiserror::Error;
 
 #[derive(Debug, PartialEq, Eq, Error)]
+/// Errors related to the textsystem
 pub enum TextError {
+    /// Font was not found, this could be that the font has not yet been loaded, or
+    /// that the font failed to load for some other reason
     #[error("font not found")]
     NoSuchFont,
+    /// Failed to add glyph to a newly created atlas for some reason
     #[error("failed to add glyph to newly-created atlas {0:?}")]
-    FailedToAddGlyph(GlyphId),
+    FailedToAddGlyph(u16),
+    /// Failed to get scaled glyph image for cache key
+    #[error("failed to get scaled glyph image for cache key: {0:?}")]
+    FailedToGetGlyphImage(CacheKey),
 }

crates/bevy_text/src/font.rs

@@ -1,53 +1,36 @@
-use ab_glyph::{FontArc, FontVec, InvalidFont, OutlinedGlyph};
+use std::sync::Arc;
+
 use bevy_asset::Asset;
 use bevy_reflect::TypePath;
-use bevy_render::{
-    render_asset::RenderAssetUsages,
-    render_resource::{Extent3d, TextureDimension, TextureFormat},
-    texture::Image,
-};
 
-#[derive(Asset, TypePath, Debug, Clone)]
+/// An [`Asset`] that contains the data for a loaded font, if loaded as an asset.
+///
+/// Loaded by [`FontLoader`](crate::FontLoader).
+///
+/// # A note on fonts
+///
+/// `Font` may differ from the everyday notion of what a "font" is.
+/// A font *face* (e.g. Fira Sans Semibold Italic) is part of a font *family* (e.g. Fira Sans),
+/// and is distinguished from other font faces in the same family
+/// by its style (e.g. italic), its weight (e.g. bold) and its stretch (e.g. condensed).
+///
+/// Bevy currently loads a single font face as a single `Font` asset.
+#[derive(Debug, TypePath, Clone, Asset)]
 pub struct Font {
-    pub font: FontArc,
+    /// Content of a font file as bytes
+    pub data: Arc<Vec<u8>>,
 }
 
 impl Font {
-    pub fn try_from_bytes(font_data: Vec<u8>) -> Result<Self, InvalidFont> {
-        let font = FontVec::try_from_vec(font_data)?;
-        let font = FontArc::new(font);
-        Ok(Font { font })
-    }
-
-    pub fn get_outlined_glyph_texture(outlined_glyph: OutlinedGlyph) -> Image {
-        let bounds = outlined_glyph.px_bounds();
-        // Increase the length of the glyph texture by 2-pixels on each axis to make space
-        // for a pixel wide transparent border along its edges.
-        let width = bounds.width() as usize + 2;
-        let height = bounds.height() as usize + 2;
-        let mut alpha = vec![0.0; width * height];
-        outlined_glyph.draw(|x, y, v| {
-            // Displace the glyph by 1 pixel on each axis so that it is drawn in the center of the texture.
-            // This leaves a pixel wide transparent border around the glyph.
-            alpha[(y + 1) as usize * width + x as usize + 1] = v;
-        });
-
-        // TODO: make this texture grayscale
-        Image::new(
-            Extent3d {
-                width: width as u32,
-                height: height as u32,
-                depth_or_array_layers: 1,
-            },
-            TextureDimension::D2,
-            alpha
-                .iter()
-                .flat_map(|a| vec![255, 255, 255, (*a * 255.0) as u8])
-                .collect::<Vec<u8>>(),
-            TextureFormat::Rgba8UnormSrgb,
-            // This glyph image never needs to reach the render world because it's placed
-            // into a font texture atlas that'll be used for rendering.
-            RenderAssetUsages::MAIN_WORLD,
-        )
+    /// Creates a [Font] from bytes, without any validation of the content
+    pub fn try_from_bytes(
+        font_data: Vec<u8>,
+    ) -> Result<Self, cosmic_text::ttf_parser::FaceParsingError> {
+        // TODO: validate font, restore `try_from_bytes`
+        use cosmic_text::ttf_parser;
+        ttf_parser::Face::parse(&font_data, 0)?;
+        Ok(Self {
+            data: Arc::new(font_data),
+        })
     }
 }