-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use static_assertions
to check for trait impls
#11407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's keep the other tests for now: these seem useful enough. We could split them out further, but I won't block on it.
Awesome! I'll remove the TODO comments. I'm going to check if any other crates use the same |
After confirmation from bevyengine#11407 (review).
@cBournhonesque, have time for a quick review? |
I couldn't find any other tests that would work for this. As long as CI passes, I think this is ready to merge. :) |
Objective
static_assertions
to automatically check this.Reflect
test in Implement TypePath for EntityHash #11195.Solution
static_assertions
and replace current tests.I wasn't sure whether to remove the existing test or not. What do you think?