System tests #36
Merged
System tests #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`decodeClosure` works without it.
Makes `stub.cpp` smaller and `trace` can be easier reused for debugging purposes.
One more option to play around...
- Use RequestPoll where possible - Better assertion for empty list - Fail if synchronization times out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests run a
Debuggee, make requests and callGHC.Debug.Clientfunctions. To guard the tests against GHC changes, they make very little assumptions.I'd like to propose this nomenclature for tests in this project:
This PR implements system tests. They make sure that
DebuggerandDebuggeecan talk to each other.Refers to #2
(Sorry, I had to close the previous PR because I mixed up GitLab WIP branches with GitHub Draft PRs.)