Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Support MagicPython grammar. #25

Merged
merged 1 commit into from
Oct 2, 2016
Merged

Conversation

lexicalunit
Copy link
Contributor

Using .name when MagicPython is installed yields "MagicPython". This is different than what the default grammar language-python yields. This causes this package to fail to execute when using MagicPython. Prefer .scopeName which should always be "source.python" no matter what.

@lexicalunit
Copy link
Contributor Author

I believe this is also a more robust solution than #21, but honestly how many Python grammars are there? I only know of MagicPython and the default language-python.

@hvdklauw
Copy link

There is also "Django Python"

Please merge this and release an update :)

@lexicalunit
Copy link
Contributor Author

I think I'm gonna fork this repo later today and make some additional changes like those I recently submitted to atom-python-yapf which operates very very similarly to this package. It's been a year since this package was last updated. I think it might be abondoned at this point :(

@lexicalunit
Copy link
Contributor Author

@hvdklauw https://atom.io/packages/atom-isort is a fork of this package that resolves: #25, #28, #27, #21 and probably a whole lot of the issues opened against this repo.

@hvdklauw
Copy link

Awesome, I'll have a look!

On Tue, 14 Jun 2016, 23:24 Amy Troschinetz, notifications@github.com
wrote:

@hvdklauw https://github.com/hvdklauw
https://atom.io/packages/atom-isort is a fork of this package that
resolves: #25 #25, #28
#28, #27
#27, #21
#21 and probably a whole
lot of the issues opened against this repo.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#25 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAA2M3Qu63hablWR5WOT4mf2dmXpg1hCks5qLxv-gaJpZM4HbQwT
.

@bh bh merged commit 5e713c8 into bh:master Oct 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants