Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish CoreSet2 constructor method #131

Open
2 of 8 tasks
ChristopherEeles opened this issue Oct 13, 2021 · 0 comments
Open
2 of 8 tasks

Finish CoreSet2 constructor method #131

ChristopherEeles opened this issue Oct 13, 2021 · 0 comments
Assignees

Comments

@ChristopherEeles
Copy link
Contributor

ChristopherEeles commented Oct 13, 2021

  • The CoreGx2 constructor will be used temporarily from the Fall 2021 to Spring 2022 releases to ensure backwards compatibility
  • Propagate the constructor changes into dependent packages
  • Once the new constructor is implemented, we can build PSets from the drug combo data Nicholas Li has been working on
  • These PSets will be used to update the summary* and signature* methods
  • Finally, we will need to refactor the monotherapy PSet creation scripts to use the new constructor
  • A deprecation warning will be added to CoreSet and other first version constructor
  • For the Spring 2022 release, we will swap CoreSet with CoreSet2, so they main constructor uses the new method
  • Finally, we will remove CoreSet2 in the Fall 2022 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant