rf(filetree): Uniformize bidsignore reading between web, CLI and test functions #113
+34
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that consistent ignores are created for web and test file trees.
effigies
changed the title
effigies
force-pushed
the
fix/uniformize-ignore
branch
from
376ac33
to
d4f133c
Compare
effigies
added a commit
to effigies/bids-validator
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Deno CLI reads the bidsignore file and then loads the filetree. The premature load isn't necessary because
FileTrees now can hold a reference to theFileIgnoreRulesobject.The web UI loads the
FileTreewithout passing them a reference to theFileIgnoreRulesobject, and then loads the bidsignore after the fact. So this has the possibility of missing ignores that bids-standard/legacy-validator#2152 was intended to address.Finally, the
pathsToTreefunction doesn't allow any ignoring at all, which limits our ability to write tests.This PR allows
filesToTreeto accept aFileIgnoreRulesobject and inject it in everyFileTreeit creates. Then we can make the web/CLI implementations work the same: build the tree, load the bidsignore. ThepathsToTreefunction can accept a list of paths or patterns.Follow-up to bids-standard/legacy-validator#2152.