Fix button clickable when disabled (#1891)

bigbinary · Oct 19, 2023 · 9f14161 · 9f14161
1 parent 963ac44
commit 9f14161
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/src/components/Button.jsx b/src/components/Button.jsx
@@ -44,18 +44,19 @@ const Button = React.forwardRef(
     },
     ref
   ) => {
-    let Parent, elementSpecificProps;
+    let Parent = motion.button;
+    let elementSpecificProps = { type };
+
     const renderLabel = label || children;
 
-    if (to) {
-      Parent = Link;
-      elementSpecificProps = { to };
-    } else if (href) {
-      Parent = motion.a;
-      elementSpecificProps = { href };
-    } else {
-      Parent = motion.button;
-      elementSpecificProps = { type };
+    if (!disabled) {
+      if (to) {
+        Parent = Link;
+        elementSpecificProps = { to };
+      } else if (href) {
+        Parent = motion.a;
+        elementSpecificProps = { href };
+      }
     }
 
     const handleClick = e => {