Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Storybook to version 8 #2365

Open
wants to merge 74 commits into
base: main
Choose a base branch
from

Conversation

yashjais
Copy link
Contributor

@yashjais yashjais commented Nov 5, 2024

This PR updates the Storybook to version 8.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@yashjais yashjais added the patch Releases small requests or bug fixes. label Nov 5, 2024
@neetodeploy neetodeploy bot had a problem deploying to neeto-ui-1f4k-pr-2365 November 5, 2024 06:35 Failure
@yashjais
Copy link
Contributor Author

yashjais commented Nov 5, 2024

Context:- Storybook isn't picking up the props from React Component and couldn't populate it in args table. The same worked when we upgraded the storybook in neeto-molecules out of the box. The core of this issue could be the warning we are getting in the console when we run yarn storybook locally. This could also be the issue behind the subcomponent props not working.

Screenshot 2024-11-05 at 12 18 33 PM

Screenshot 2024-11-05 at 12 20 29 PM

@AbhayVAshokan _a

You could checkout to this branch(test-2333-show-the-props-of-subcomponents-in-storybook) to check the react-docgen issue. In this branch I've extra commit to match the version of packages with neeto-molecules. Also copied the main file in storybook from neeto-molecules to remove any config issue.

Here's the diff between dependencies for neeto-ui and neeto-molecules.

Few of the approaches I've tried to get this working.

  • Matched the packages and config of neeto-ui and neeto-molecules to get this working in neeto-ui.
  • Tried to update the configs in main.js file of storybook.

Here are few links related to this issue.
https://storybook.js.org/docs/api/main-config/main-config-typescript#reactdocgen
https://github.com/reactjs/react-docgen/issues
storybookjs/storybook#29378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the props of subcomponents in Storybook
2 participants