Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Palette component in ColorPicker to remove the Tailwind dependency for the colors. #2390

Closed
deepakjosp opened this issue Dec 3, 2024 · 2 comments · Fixed by #2392
Assignees
Labels
PR The issue has a PR associated with it.

Comments

@deepakjosp
Copy link
Contributor

@praveen-murali-ind as per our discussion let's refactor the Palette component to avoid the tailwind dependency and implement a more straightforward and simple way similar to what the react-colorful has implemented for the color boxes.

This includes the change in the color list prop of the palette to an array of color values and using those instead of the color bg classes and gradient as an inline style. These are breaking changes, we will have to refactor the usages in NeetoDesk and NeetoWireframe.

cc: @josephmathew900

Originally posted by @deepakjosp in #2385 (comment)

@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a could you please assign this to someone to work on?

cc: @praveen-murali-ind

@deepakjosp
Copy link
Contributor Author

@deepakjosp _a

@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned josephmathew900 Dec 4, 2024
@neetogit-bot neetogit-bot bot added working A branch associated with this issue is created. PR The issue has a PR associated with it. labels Dec 4, 2024
@neetogit-bot neetogit-bot bot removed the working A branch associated with this issue is created. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR The issue has a PR associated with it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants