Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed disabled prop of Dropdown not working when a customTarget is used #2291

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented Aug 26, 2024

Description

  • Fixed: disabled prop of Dropdown not working when a customTarget is used

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.

  • I have verified the functionality in some of the neeto web-apps.
    - [ ] I have added tests that prove my fix is effective or that my feature works.
    - [ ] I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@josephmathew900 _a

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2291 August 26, 2024 12:15 Inactive
@gaagul gaagul added the patch Releases small requests or bug fixes. label Aug 26, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2291 August 26, 2024 12:23 Inactive
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit da34933 into main Aug 26, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2288-dropdown-disabled-custom-target branch August 26, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabled prop of Dropdown does not work when a customTarget is used
2 participants