Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dayjs timezone issue with datepicker #2298

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Fixed dayjs timezone issue with datepicker #2298

merged 1 commit into from
Aug 29, 2024

Conversation

josephmathew900
Copy link
Contributor

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@josephmathew900
Copy link
Contributor Author

@AbhayVAshokan @gaagul Please test the changes in this PR in a few Neeto products.

@josephmathew900 josephmathew900 marked this pull request as ready for review August 29, 2024 05:30
@josephmathew900 josephmathew900 added the patch Releases small requests or bug fixes. label Aug 29, 2024
@josephmathew900 josephmathew900 merged commit ed80072 into main Aug 29, 2024
1 check failed
@josephmathew900 josephmathew900 deleted the 2296-fix-dayjs-timzeone-issue-with-datepicker branch August 29, 2024 05:30
josephmathew900 added a commit that referenced this pull request Aug 29, 2024
@josephmathew900
Revert "Fixed dayjs timezone issue with datepicker (#2298)"
37dadb4 
This reverts commit ed80072.
@josephmathew900 josephmathew900 mentioned this pull request Aug 29, 2024
Merged
AbhayVAshokan pushed a commit that referenced this pull request Aug 29, 2024
@josephmathew900
Revert "Fixed dayjs timezone issue with datepicker (#2298)" (#2301)
7e4a185 
This reverts commit ed80072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees
No one assigned
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selected date isn't reflected correctly after recent dayjs changes #1256
2 participants
@josephmathew900 @AbhayVAshokan