Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased the zIndex of the table header menu to fix the visibility issue in the overlay components. #2320

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Sep 24, 2024

Description
The menu was not visible in the overlay components like Pane. To fix that increased the zIndex from the 9999 which was the default value of Tippy to 99999.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2320 September 24, 2024 12:31 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Sep 24, 2024
@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a please review.

Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit c2f8145 into main Sep 25, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2319-more-dropdown-on-column-header-doesnt-show-any-dropdown-on-pane-and-is-present-by-default branch September 25, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More dropdown on column header doesn't show any dropdown on pane and is present by default
2 participants