Fixes the formik submit handler returning a promise for synchronous submit handlers which in turn immediately sets the isSubmitting to false. #2357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
async
handleSubmit
will always return aPromise
, even if the submit handler inside doesn’t return one. This leads to unexpected bugs, as thePromise
resolves immediately when using themutate
function ofuseMutation
while the API call might still be in progress.Checklist
I have made corresponding changes to the documentation.I have updated the types definition of modified exports.I have added properdata-cy
anddata-testid
attributes.patch
/minor
/major
- If package publishis required).
Reviewers