Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null object check for toastr #2360

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Added null object check for toastr #2360

merged 1 commit into from
Oct 30, 2024

Conversation

udai1931
Copy link
Contributor

@udai1931 udai1931 commented Oct 29, 2024 •
edited
Loading

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@udai1931 udai1931 added the patch Releases small requests or bug fixes. label Oct 29, 2024
@udai1931
Copy link
Contributor Author

@deepakjosp _a please check

deepakjosp
deepakjosp approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@deepakjosp deepakjosp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepakjosp deepakjosp merged commit df1668e into main Oct 30, 2024
1 check passed
@deepakjosp deepakjosp deleted the 590-null-object-toastr-fix branch October 30, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakjosp deepakjosp deepakjosp approved these changes

Assignees

@deepakjosp deepakjosp

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udai1931 @deepakjosp