Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the toastr icon by default #2367

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Removed the toastr icon by default #2367

merged 10 commits into from
Nov 12, 2024

Conversation

philson-philip
Copy link
Contributor

@philson-philip philson-philip commented Nov 8, 2024 •
edited by josephmathew900
Loading

Description

  • Removed the toastr icon by default.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers
@deepakjosp _a Please add the test cases as we discussed during the call.

@philson-philip philson-philip added the patch Releases small requests or bug fixes. label Nov 8, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2367 November 8, 2024 12:14 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2367 November 8, 2024 12:26 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2367 November 11, 2024 03:20 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2367 November 11, 2024 03:42 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2367 November 11, 2024 04:21 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2367 November 11, 2024 06:36 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2367 November 11, 2024 06:50 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2367 November 11, 2024 06:55 Inactive
@deepakjosp
Copy link
Contributor

@josephmathew900 _a please review.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned deepakjosp Nov 11, 2024
josephmathew900
josephmathew900 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit 6a7b5b2 into main Nov 12, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2366-removed-toastr-icon-by-default branch November 12, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the icon from the Toastr component by default
3 participants
@philson-philip @deepakjosp @josephmathew900