Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert static px values to rem for improved accessibility and scalability #2380

Merged
merged 19 commits into from
Nov 21, 2024
Merged

Convert static px values to rem for improved accessibility and scalability #2380

merged 19 commits into from
Nov 21, 2024

Conversation

praveen-murali-ind
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind commented Nov 21, 2024 •
edited
Loading

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@praveen-murali-ind _a

@praveen-murali-ind
Convert px units to rem in Button component
ef57b59
@praveen-murali-ind
Convert px units to rem in Spinner component
0bf3aa6
@praveen-murali-ind
Convert px units to rem in Checkbox component
ac606a4
@praveen-murali-ind
Convert px units to rem in Radio component
df24c1a
@praveen-murali-ind
Convert px units to rem in Switch component
3accfca
@praveen-murali-ind
Convert px units to rem in Input component
69a5172
@praveen-murali-ind
Convert px units to rem in Select component
0479b63
@praveen-murali-ind
Convert px units to rem in Dropdown component
13f2378
@praveen-murali-ind
Convert px units to rem in Email component
9314ae6
@praveen-murali-ind
Convert px units to rem in Tag component
35fd2b4
@praveen-murali-ind
Convert px units to rem in Tab component
6124805
@praveen-murali-ind
Convert px units to rem in Accordion component
861c56a
@praveen-murali-ind
Convert px units to rem in Avatar component
69cfb13
@praveen-murali-ind
Convert px units to rem in Pagination component
8b19195
@praveen-murali-ind
Convert px units to rem in ColorPicker component
3583627
@praveen-murali-ind
Convert px units to rem in Date component
16569b2
@praveen-murali-ind
Convert px units to rem in Time component
09d8cbf
@praveen-murali-ind
Convert px units to rem in KBD component
755b08b
@praveen-murali-ind
Convert px units to rem in Modal component
3a48ea8
@praveen-murali-ind praveen-murali-ind added the patch Releases small requests or bug fixes. label Nov 21, 2024
@praveen-murali-ind
Copy link
Contributor Author

cc @josephmathew900

@praveen-murali-ind praveen-murali-ind merged commit 618602d into main Nov 21, 2024
1 check passed
@praveen-murali-ind praveen-murali-ind deleted the 2378-convert-px-to-rem branch November 21, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@praveen-murali-ind praveen-murali-ind

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert static px values to rem for improved accessibility and scalability
1 participant
@praveen-murali-ind