Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the DatePicker to sanitize the value to the allowed limit only if user has changed the value. #2381

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Updated the DatePicker to sanitize the value to the allowed limit only if user has changed the value. #2381

merged 4 commits into from
Nov 27, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Nov 26, 2024 •
edited
Loading

Fixes #2371

Description

  • Updates the value and default value fixed to the allowed range only if the user has touched the fields. This will fix the values outside the allowed ranges until not properly rendered initially.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2381 November 26, 2024 09:37 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Nov 26, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2381 November 26, 2024 10:09 Inactive
@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a please review.

josephmathew900
josephmathew900 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2381 November 27, 2024 04:28 Inactive
@josephmathew900 josephmathew900 merged commit 938f5bd into main Nov 27, 2024
1 check was pending
@josephmathew900 josephmathew900 deleted the 2371-we-should-not-reset-the-selected-time-to-mindate-for-already-saved-values branch November 27, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should not reset the selected time to minDate for already saved values
2 participants
@deepakjosp @josephmathew900