Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon color in Toaster #2384

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Fix icon color in Toaster #2384

merged 4 commits into from
Nov 27, 2024

Conversation

praveen-murali-ind
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind commented Nov 27, 2024

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp _a

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2384 November 27, 2024 04:40 Inactive
@praveen-murali-ind praveen-murali-ind added the patch Releases small requests or bug fixes. label Nov 27, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2384 November 27, 2024 04:42 Inactive
@deepakjosp
Copy link
Contributor

@josephmathew900 _a please review.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned deepakjosp Nov 27, 2024
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @deepakjosp _a Please add the description and merge the PR.

@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned josephmathew900 Nov 27, 2024
@deepakjosp deepakjosp merged commit 82a4d0d into main Nov 27, 2024
1 check passed
@deepakjosp deepakjosp deleted the 2379-fix-toaster-styling branch November 27, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon classname and other props not reflected to the toastr icon
3 participants