Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker improvements #2385

Merged
merged 13 commits into from
Dec 4, 2024
Merged

Color picker improvements #2385

merged 13 commits into from
Dec 4, 2024

Conversation

praveen-murali-ind
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind commented Nov 27, 2024

Changes

  • Improved: spacing.
  • Enabled: # prefix displaying.
  • Enabled: eye picker by default.
  • Updated: color palette styles.
  • Updated: color input styles.
  • Updated: color picker icon.
Screenshot 2024-11-27 at 2 26 58 PM
Screenshot 2024-11-27 at 10 29 29 AM

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp _A

@praveen-murali-ind
Copy link
Contributor Author

praveen-murali-ind commented Nov 27, 2024

@deepakjosp _a Could you please work on the following?

  • Show color palette by default. For now we can use the color values in the Storybook.
Screenshot 2024-11-27 at 2 37 25 PM

cc @josephmathew900

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2385 November 27, 2024 09:21 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2385 November 27, 2024 09:22 Inactive
@deepakjosp
Copy link
Contributor

@praveen-murali-ind as per our discussion let's refactor the Palette component to avoid the tailwind dependency and implement a more straight forward and simple way similar to what the react-colorful has implemented for the color boxes. This includes the change in the color list prop of the palette to array of color values and use those instead of the color bg classes and gradient as an inline style. Also these are breaking changes, we will have to refactor the usages in NeetoDesk and NeetoWireframe.

cc: @josephmathew900

@deepakjosp
Copy link
Contributor

deepakjosp commented Dec 3, 2024

@praveen-murali-ind _a let's merge the PR with the current changes. Color palette changes can be taken up as a separate issue.

@praveen-murali-ind praveen-murali-ind marked this pull request as ready for review December 3, 2024 12:57
@praveen-murali-ind praveen-murali-ind added the patch Releases small requests or bug fixes. label Dec 3, 2024
@deepakjosp
Copy link
Contributor

@josephmathew900 _a I've updated the jest.config. Please review.

Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit 459b478 into main Dec 4, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2374-better-color-picker branch December 4, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better color picker
3 participants