Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors the Palette comopnent in ColorPicker to remove the tailwind dependency. #2392

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Refactors the Palette comopnent in ColorPicker to remove the tailwind dependency. #2392

merged 7 commits into from
Dec 5, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Dec 4, 2024 •
edited
Loading

Fixes #2390

Description

  • Updates the color palette to support hex values and removes the tailwind dependency.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp deepakjosp self-assigned this Dec 4, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2392 December 4, 2024 11:49 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2392 December 5, 2024 06:21 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2392 December 5, 2024 06:24 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Dec 5, 2024
@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a please review. Please don't merge. I'll merge it once the product PRs are approved.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned deepakjosp Dec 5, 2024
josephmathew900
josephmathew900 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakjosp _a Added a minor suggestion. Rest LGTM.

src/components/ColorPicker/Palette.jsx Outdated Show resolved Hide resolved
@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned josephmathew900 Dec 5, 2024
@deepakjosp deepakjosp merged commit 3cc6448 into main Dec 5, 2024
1 check passed
@deepakjosp deepakjosp deleted the 2390-refactor-the-palette-component-in-colorpicker-to-remove-the-tailwind-dependency-for-the-colors branch December 5, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@deepakjosp deepakjosp

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the Palette component in ColorPicker to remove the Tailwind dependency for the colors.
2 participants
@deepakjosp @josephmathew900