Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pruning saved emails when there's a duplicate entry. #2398

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Dec 9, 2024

Description

  • Skips over writing the saved email details with the duplicate email entered by the user.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a please review.

Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit 0cb8109 into main Dec 10, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2377-multiemailinput-prunes-saved-emails-when-theres-a-duplicate branch December 10, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiEmailInput prunes saved emails when there's a duplicate.
2 participants