Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shows color palette by default in the ColorPicker. #2400

Merged
merged 9 commits into from
Dec 10, 2024
Merged

Shows color palette by default in the ColorPicker. #2400

merged 9 commits into from
Dec 10, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Dec 9, 2024 •
edited
Loading

Fixes #2397

Description

  • Shows the color palette in the color picker by default.
  • Updates the color list and the onChange handler to align with the color and onChange handler of the picker.
  • Refactors and cleans up the onChange handlers and the associated functions.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2400 December 9, 2024 13:15 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Dec 9, 2024
@neetodeploy neetodeploy bot had a problem deploying to neeto-ui-1f4k-pr-2400 December 9, 2024 13:29 Failure
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2400 December 9, 2024 13:36 Inactive
@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a please review.

@deepakjosp
Copy link
Contributor Author

@praveen-murali-ind _a please review.

praveen-murali-ind
praveen-murali-ind approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @josephmathew900 _A Please review.

josephmathew900
josephmathew900 reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakjosp _a https://joseph-mathew.neetorecord.com/watch/db8a6e4d-1e82-4e74-8c1a-682b27ae8310

@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned josephmathew900 Dec 10, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2400 December 10, 2024 16:07 Inactive
@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a fixed. Please review.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned deepakjosp Dec 10, 2024
josephmathew900
josephmathew900 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit 6779378 into main Dec 10, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2397-display-color-palette-by-default-in-colorpicker branch December 10, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveen-murali-ind praveen-murali-ind praveen-murali-ind approved these changes

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display color palette by default in ColorPicker
3 participants
@deepakjosp @josephmathew900 @praveen-murali-ind