-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to sign tx with single key or array of keys #238
base: master
Are you sure you want to change the base?
Conversation
Pop out the first element (if an array) in the `rest attributes` and use that as the privateKeys array. Also use first private key if there are not enough supplied.
Add support for single and array of private keys
Before we can merge this pull request, we need you or your organization to agree to one of our contributor agreements. One of the big concerns for people using and developing open source software is that someone who contributed to the code might claim the code infringes on their copyright or patent. To guard against this, we ask all our contributors to sign a Contributor License Agreement. This gives us the right to use the code contributed and any patents the contribution relies on. It also gives us and our users comfort that they won't be sued for using open source software. We know it's a hassle, but it makes the project more reliable in the long run. Thank you for your understanding and your contribution! If you are contributing on behalf of yourself (and not on behalf of your employer or another organization you are part of) then you should:
If you're contributing as an employee, and/or you want all employees of your employing organization to be covered by our contributor agreement, then someone in your organization with the authority to enter agreements on behalf of all employees must do the following:
We will email you (or your employer) with further instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis tests are failing.
What about if you change just line 239 for:
const privateKey = privateKeys[index] ? privateKeys[index] : privateKeys[0]
Hi @robertdavid010 any update here? |
Have to discuss with current project to confirm signing. Can request addressing of this maybe today or tomorrow.
… On Aug 24, 2018, at 11:33 AM, Manolo ***@***.***> wrote:
Hi @robertdavid010 <https://github.com/robertdavid010> what is the status of this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#238 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACKG685Q4P7KFYyfQQsuD6GYPdbYKpKKks5uT8h0gaJpZM4V-BCd>.
|
Pop the first element out if its an array, and fallback to the first key if the array runs out of keys.
Closes #237