feat(component): support button as anchor #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing until TS 4.8 |
|
Additional context, the last missing piece is that the even on things like TS 4.8 is out but this is still an issue. Try again in the future, this Playground should pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds support for rendering a button as an anchor.
Why?
While we discourage this usage, we have some edge cases where we still need it. Some apps are working around it and we should support their use case.
Screenshots/Screen Recordings
Proper types when changing it to an anchor:
Doesn't allow anchor props by default:
Disallows any other tag:
Caveat:
The
disabledprop is not fully supported for anchor tags. It will disable click events but it still tab accessible. While we can support this it's not part of the spec and we probably shouldn't be disabling links. We can revisit this if required in the future.Testing/Proof
👀 unit test.
Closes #430