Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA-18260: Add extra logging for requests without ACL tokens #591

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

mattclement
Copy link

This adds the abilty to enable extra logging when log_acl_info = true. It is intended to log requests that don't contain ACL info, to facilitate safer ACL enablement.

No logs are generated with the flag off / absent, or when there is a token present.

Logs look like this:

{
  "@level": "info",
  "@message": "No ACL token in request",
  "@module": "agent.http",
  "@timestamp": "2024-09-11T12:30:21.105571-04:00",
  "remote_addr": "127.0.0.1:56100",
  "url": "/v1/kv/",
  "user_agent": "curl/8.7.1"
}

@mattclement mattclement merged commit f03fae6 into v1.19.1-bc Sep 12, 2024
13 of 41 checks passed
@mattclement mattclement deleted the INFRA-18260 branch September 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants