Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA-18260: Use parseTokenInternal to avoid setting default token #596

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mattclement
Copy link

Description

parseToken sets the default token if none are included. My testing with consul agent -dev didn't have a default token, so this behavior was missed.

Testing & Reproduction steps

config.hcl

log_acl_info = true
log_json = true
acl {
  tokens {
    default = "asdf"
  }
}

Build and run against the above file: consul agent -dev -config-file config.hcl

With this patch, curl localhost:8500/v1/kv/foo correctly emits the log indicating a missing ACL token. Without the patch, no log is emitted.

@mattclement mattclement requested review from chrisboulton and a team September 16, 2024 17:46
@mattclement mattclement merged commit cd199d2 into v1.19.1-bc Sep 16, 2024
13 of 41 checks passed
@mattclement mattclement deleted the INFRA-18260-2 branch September 16, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants