Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zh locale #2171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add zh locale #2171

wants to merge 2 commits into from

Conversation

imgarylai
Copy link

What?

Add zh and zh-TW locale

Requirements

N/A

Tickets / Documentation

N/A

Screenshots (if appropriate)

N/A

@BC-krasnoshapka
Copy link
Contributor

hi @imgarylai
thanks for your effort with translations. BigCommerce provides official translations for Cornerstone, storefront and other services. We're still working on supporting Chinese languages across storefront and other services, so for now we can't accept your PR because translations won't be complete across all interfaces. But we'll definitely use your work as a base.

@imgarylai
Copy link
Author

hi @imgarylai thanks for your effort with translations. BigCommerce provides official translations for Cornerstone, storefront and other services. We're still working on supporting Chinese languages across storefront and other services, so for now we can't accept your PR because translations won't be complete across all interfaces. But we'll definitely use your work as a base.

Thank you @BC-krasnoshapka . Please let me know if you have any helps regrading the Mandarin translations. We have been using this translation in our store for two years. (But I forgot the reason why I didn't create the PR.) The store theme we are using is cornerstone. And we really want to keep the theme up to date with the upstream which is here.

Looking forward to see Big Commerce supports Mandarin translations.

Happy Lunar new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants