Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add error traces #145

Merged
merged 3 commits into from
Mar 4, 2024
Merged

feature: add error traces #145

merged 3 commits into from
Mar 4, 2024

Conversation

bc-micah
Copy link
Collaborator

@bc-micah bc-micah commented Mar 4, 2024

What?

  • add tracing for every error response
  • standardize the formatting of tracing event names
  • improve bc load jwt token test

Why?

  • have information on errors in trace explorer
  • make sure jsonwebtoken library changes don't unexpectedly break app load like it did with aud validation.

Testing/Proof

Screenshot 2024-03-04 at 9 58 41 AM

important that we add `aud` field in jwt to make sure validation of `aud` by jsonwebtoken library does not break app in future
@bc-micah bc-micah merged commit 3b515ca into main Mar 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant