Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorten long table entries #328

Open
ivokwee opened this issue Apr 21, 2023 · 2 comments
Open

shorten long table entries #328

ivokwee opened this issue Apr 21, 2023 · 2 comments
Labels
lacks info Issue needs more description before it can be addressed

Comments

@ivokwee
Copy link
Member

ivokwee commented Apr 21, 2023

Problem: In many table we have long descriptions that force the table to be very wide or overflow.

possbile solution: In some table we have truncated the descriptions, a better solution is to use a JS snippet like in Pathway analysis > wikipathways > Enrichment table. It inserts this JS (found somewhere...)

          columnDefs = list(list(
            targets = 1, ## with no rownames column 1 is column 2
            render = DT::JS(
              "function(data, type, row, meta) {",
              "return type === 'display' && data.length > 50 ?",
              "'<span title=\"' + data + '\">' + data.substr(0, 50) + '...</span>' : data;",
              "}")
          ))

The other points is that many long geneset names are often having lots of underscores instead of spaces preventing the cell to wrap to newline. Perhaps substituting the underscore in the table may also be good idea if wrap newline is permitted. The dataset loading table have this.

@ncullen93 ncullen93 added the uncloseable This issue is written such that the conditions to close the issue can never be acheived. label Jun 14, 2023
@ncullen93
Copy link
Contributor

Marking as uncloseable because there is no way to know when we have solved this problem in "many tables" with long descriptions. I recommend either closing the issue or adding info about specific tables which have this issue along with a way to reproduce the issue. Otherwise, this issue will just stay open forever.

@ivokwee
Copy link
Member Author

ivokwee commented Jun 18, 2023

This is an issue and should not be closed until solved. If the description is not precise enough to be closable, and you don't feel like solving this bug yourself, you should at least help to make the description better, go through all tables that need it and report the list here for the one that want to tackle this issue.

@ncullen93 ncullen93 added lacks info Issue needs more description before it can be addressed and removed uncloseable This issue is written such that the conditions to close the issue can never be acheived. labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lacks info Issue needs more description before it can be addressed
Projects
None yet
Development

No branches or pull requests

2 participants