Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model not saved ... #5

Open
unktkn opened this issue Oct 18, 2019 · 0 comments
Open

Model not saved ... #5

unktkn opened this issue Oct 18, 2019 · 0 comments

Comments

@unktkn
Copy link

unktkn commented Oct 18, 2019

Hi there,

Thanks for the code. It would have been much nicer if you would have also included the code for saving the trained model (e.g. while running eval.py ) and than reloading the model to run prediction.
Moreover, with the current code if I run the eval.py, ComplexHRERE::evaluate(..) is called, and it is not even checked if the current model state has the best score on validation set :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant