add support for idasdk83, fix logs in run() function

binarly-io · Oct 7, 2024 · d3bd633 · d3bd633
1 parent 6fde36f
commit d3bd633
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/efiXplorer/efi_utils.cc b/efiXplorer/efi_utils.cc
@@ -299,6 +299,7 @@ ea_list_t efi_utils::get_xrefs_to_array(ea_t addr) {
 //--------------------------------------------------------------------------
 // wrapper for op_stroff function
 bool efi_utils::op_stroff(ea_t addr, std::string type) {
+#if IDA_SDK_VERSION >= 840
   tinfo_t tinfo;
   if (!tinfo.get_named_type(get_idati(), type.c_str())) {
     return false;
@@ -310,6 +311,9 @@ bool efi_utils::op_stroff(ea_t addr, std::string type) {
   if (tid == BADADDR) {
     return false;
   }
+#else
+  tid_t tid = get_struc_id(type.c_str());
+#endif
 
   insn_t insn;
   decode_insn(&insn, addr);

diff --git a/efiXplorer/efixplorer.cc b/efiXplorer/efixplorer.cc
@@ -98,14 +98,14 @@ bool idaapi run(size_t arg) {
     warning("%s: input file is UEFI firmware, analysis can be time consuming\n",
             g_plugin_name);
     if (get_machine_type() == AARCH64) {
-      efi_utils::log("[%s] analyse ARM64 modules\n");
+      efi_utils::log("analyse ARM64 modules\n");
       efi_analysis::efi_analyse_main_aarch64();
     } else {
-      efi_utils::log("[%s] analyse AMD64 modules\n", g_plugin_name);
+      efi_utils::log("analyse AMD64 modules\n");
       efi_analysis::efi_analyse_main_x86_64();
     }
   } else if (arch == arch_file_type_t::aarch64) {
-    efi_utils::log("[%s] input file is ARM 64-bit module\n");
+    efi_utils::log("input file is ARM 64-bit module\n");
     efi_analysis::efi_analyse_main_aarch64();
   }