Merge branch 'release/9.5.11'

* release/9.5.11: Final commit of version 9.5.11 fix replay bugs and bump
binarykitchen · Oct 7, 2024 · 7cd9b43 · 7cd9b43
2 parents 27d0063 + 0a85f38
commit 7cd9b43
Show file tree

Hide file tree

Showing 8 changed files with 33 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "videomail-client",
-  "version": "9.5.8",
+  "version": "9.5.10",
   "description": "A wicked npm package to record videos directly in the browser, wohooo!",
   "keywords": [
     "webcam",

diff --git a/prototype/correct_existing_videomail.html b/prototype/correct_existing_videomail.html
@@ -11,7 +11,7 @@
         margin: 1em 0;
         display: block;
       }
-      #videomail,
+      #videomail .visuals,
       #email {
         float: left;
       }
@@ -27,7 +27,9 @@
   </head>
   <body>
     <h1>A form to correct an existing videomail</h1>
-    <div id="videomail"></div>
+    <div id="videomail">
+      <div class="visuals" />
+    </div>
     <form id="email">
       <fieldset>
         <input name="key" value="" type="hidden" />

diff --git a/prototype/js/videomail-client.js b/prototype/js/videomail-client.js
@@ -16434,7 +16434,7 @@ function wrappy (fn, cb) {
 },{}],110:[function(_dereq_,module,exports){
 module.exports={
   "name": "videomail-client",
-  "version": "9.5.9",
+  "version": "9.5.11",
   "description": "A wicked npm package to record videos directly in the browser, wohooo!",
   "keywords": [
     "webcam",
@@ -19276,7 +19276,9 @@ var Container = function Container(options) {
         }
       }
       !built && initEvents(buildOptions.playerOnly);
-      correctDimensions();
+      if (!buildOptions.playerOnly) {
+        correctDimensions();
+      }
 
       // Building form also applies for when `playerOnly` because of
       // correcting mode on Videomail. This function will skip if there is no form. Easy.
@@ -20199,7 +20201,11 @@ var Visuals = function Visuals(container, options) {
     var replayParentElement = arguments.length > 1 ? arguments[1] : undefined;
     debug("Visuals: build (playerOnly=".concat(playerOnly, ")"));
     if (container) {
-      visualsElement = container.querySelector(".".concat(options.selectors.visualsClass));
+      if (replayParentElement) {
+        visualsElement = replayParentElement.querySelector(".".concat(options.selectors.visualsClass));
+      } else {
+        visualsElement = container.querySelector(".".concat(options.selectors.visualsClass));
+      }
       if (!visualsElement) {
         if (playerOnly && replayParentElement) {
           visualsElement = replayParentElement;
@@ -20227,7 +20233,7 @@ var Visuals = function Visuals(container, options) {
     }
     correctDimensions();
     !built && initEvents(playerOnly);
-    buildChildren(playerOnly, replayParentElement);
+    buildChildren(playerOnly, visualsElement || replayParentElement);
     built = true;
   };
   this.querySelector = function (selector) {

diff --git a/prototype/js/videomail-client.min.js b/prototype/js/videomail-client.min.js
diff --git a/prototype/js/videomail-client.min.js.map b/prototype/js/videomail-client.min.js.map
diff --git a/src/wrappers/container.js b/src/wrappers/container.js
@@ -434,7 +434,9 @@ const Container = function (options) {
 
       !built && initEvents(buildOptions.playerOnly);
 
-      correctDimensions();
+      if (!buildOptions.playerOnly) {
+        correctDimensions();
+      }
 
       // Building form also applies for when `playerOnly` because of
       // correcting mode on Videomail. This function will skip if there is no form. Easy.

diff --git a/src/wrappers/visuals.js b/src/wrappers/visuals.js
@@ -131,7 +131,13 @@ const Visuals = function (container, options) {
     debug(`Visuals: build (playerOnly=${playerOnly})`);
 
     if (container) {
-      visualsElement = container.querySelector(`.${options.selectors.visualsClass}`);
+      if (replayParentElement) {
+        visualsElement = replayParentElement.querySelector(
+          `.${options.selectors.visualsClass}`,
+        );
+      } else {
+        visualsElement = container.querySelector(`.${options.selectors.visualsClass}`);
+      }
 
       if (!visualsElement) {
         if (playerOnly && replayParentElement) {
@@ -165,7 +171,7 @@ const Visuals = function (container, options) {
     correctDimensions();
 
     !built && initEvents(playerOnly);
-    buildChildren(playerOnly, replayParentElement);
+    buildChildren(playerOnly, visualsElement || replayParentElement);
 
     built = true;
   };