Merge branch 'release/5.1.0'

* release/5.1.0:
  Final commit of version 5.1.0
  Introduce new loadUserMediaOnRecord option

.eslintrc.js

@@ -8,15 +8,11 @@ module.exports = {
     'plugin:import/errors',
     'plugin:import/warnings'
   ],
-  root: true,
   env: {
     browser: true,
     es6: true
   },
   rules: {
-    'no-debugger': 0,
-    'import/no-named-as-default': 0,
-    'no-else-return': 1,
     'space-before-function-paren': [
       'error',
       {

.github/workflows/release.yml

@@ -34,6 +34,7 @@ jobs:
           SLUG: videomail-for-ninja-forms
 
       - name: Upload release asset
+        # TODO Switch to another action as this one is deprecated. Maybe softprops/action-gh-release
         uses: actions/upload-release-asset@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.prettierrc.js

@@ -0,0 +1,13 @@
+//@ts-check
+
+// Note: whatever prettier defaults, remove
+
+/** @type {import('prettier').Config} */
+const config = {
+  "printWidth": 90,
+  "semi": false,
+  "singleQuote": true,
+  "trailingComma": "none"
+};
+
+module.exports = config;

README.md

@@ -58,14 +58,15 @@ https://github.com/binarykitchen/videomail-for-ninja-forms/issues
 ## Releasing
 
 1. Update changelog in readme.txt (stable tag + changelog)
-2. Manually bump versions in
+2. Search for current version and replace it with the new one. Should be these files:
    - package.json
    - readme.txt
    - videomail-for-ninja-forms.php
    - src/php/videomail.php
 3. Optional: validate readme.txt with https://wordpress.org/plugins/developers/readme-validator/
 4. Run `npm run release`
 5. Tag a new release which will run the release workflow on GitHub, e.g. with `gh release create`
+6. Announce on Twitter
 
 ## Ask for help
 

TODO.md

@@ -1,6 +1,6 @@
 ### TODOs
 | Filename | line # | TODO
 |:------|:------:|:------
-| js/main.js | 162 | isn't 'form-' + formModel.get('id') the same as the formID already?
-| js/main.js | 230 | ask for an endpoint to process those special merge tags
+| js/main.js | 167 | isn't 'form-' + formModel.get('id') the same as the formID already?
+| js/main.js | 235 | ask for an endpoint to process those special merge tags
 | gulpfile.js | 65 | fix, sourcemaps do not seem to work (switch to webpack?)