flash bump #9088
Closed
flash bump #9088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mictadlo
commented
May 30, 2018
mictadlo
commented
- I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
bgruening
reviewed
May 31, 2018
|
|
||
| extra: |
There was a problem hiding this comment.
Why have you removed this? its still the same tool isn't it?
Is there a publication which we can reference?
bgruening
reviewed
May 31, 2018
| version: {{ version }} | ||
|
|
||
| build: | ||
| number: 1 |
|
I’m uncertain as to the status of how FLASH2 relates to FLASH. Looking at the GitHub repository, it seems that the project is an independent one (not from the original authors). Perhaps @dstreett could explain? According to dstreett/FLASH2#2, the behavior is also slightly different, so perhaps it woud be an idea to put this into a separate recipe named |
|
It it is really a separate "tool" than a new recipe would be preferred, I agree. |
|
I created a new PR #9103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.