-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Multilingual distribution #246
Conversation
otherwise it is not installable
On Friday we tested sloppily: contents of the first build I fixed
I did not check whether anything works though - for now I just tried to ensure that files are translated. |
TODO:
|
I'm working on it. |
Windows build fails with |
Ok, fixed the previous problem. Now the problem is that, inside trubar, |
986cacd
to
84ee57e
Compare
PyQt6 do not pass because we still haven't fixed them in any add-on. Now Windows tests are still not working. Waiting for a proper Trubar release. If they then pass, we merge. |
Orange 3.38 might support switching between languages. This is a draft of how add-ons would support that.
We would upload original sources to PyPi and run translation during installation. Add-on is "translated" if (see here)
install
(notdevelop
),trubar
is installed. I propose we'd make it a requirement although Orange doesn't depend on it -- only translation of add-ons does. (Note: the current release of Trubar supports only translation to a single language, not switching. This PR suppose a new version which is still in development.)If add-on supports multiple languages but Orange doesn't, or vice-versa, everything should work.
pip install -e .
orpython setup.py develop
should keep source intact. Hence developers wouldn't (have to) notice that add-ons become multilingual when installed. Orange itself would also only be translated when preparing the release, not earlier.Note: this only works if add-on is installed via
python setup.py install
orpip install --no-build-isolation .
. Without--no-build-isolation
, pip creates some kind of temporary virtual environment that has nothing but built-in Python modules.@markotoplak, thanks for bringing setup.py to my attention. What do you think about this?
To do:
InstallMultilingualCommand
to another place (where?!?!) where it can be shared between add-ons?