Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a way to exclude some GO rules when parsing a GAF file #544

Open
valearna opened this issue Mar 26, 2021 · 6 comments
Open
Assignees

Comments

@valearna
Copy link
Contributor

To generate the Alliance gene descriptions, I'm loading GO obo file and the GAF files for the MODs with ontobio, but GO rule 26 is skipping IBA annotations. Is there a way to exclude a specific rule when parsing the GAFs? I'm happy to work on a PR if needed.

@dustine32
Copy link
Collaborator

Hey @valearna! I used to have this problem too. Somewhere in the AssocParserConfig there is a paint attribute that can be set to True to allow IBA annotations. Oh here it is:

paint=False,

Let me know if you need more info!

@valearna
Copy link
Contributor Author

Thanks @dustine32!

@cmungall
Copy link
Contributor

I find it surprising that filtering is the default behavior!

GO team - remember ontobio is a general purpose framework that includes functionality for things like parsing GAFs. We of course want to use this general purpose framework to do things like implement specific rules such as filtering IBA from non-paint sources when run in a specific context.

Even for our own internal GOC purposes this default behavior could come back and bite us. Let us say we rewrite the solr loadiing in python. If we load the outputs of the pipeline then if we do not remember the magic flag we will accidentally filter

@valearna - thanks for the report we will prioritize fixing the behavior!

@kltm kltm changed the title Is there a way to exclude some GO rules when parsing a GAF file? There should be a way to exclude some GO rules when parsing a GAF file Mar 27, 2021
@kltm
Copy link
Member

kltm commented Mar 27, 2021

To clarify maybe, the general/default case should not apply the rules, the optional/GO cases should be explicitly turned on.
A fix here for us then would look like shifting the default behavior and adding the hooks to turn what we want on at need.

@valearna
Copy link
Contributor Author

Thanks again for checking my PR on agr_loader @cmungall. I've set the attribute paint=True and now everything works as expected. I agree that it would be much more intuitive to have the attribute set to True by default.

@cmungall
Copy link
Contributor

...and we should use a more meaningful flag name! paint=True is the height of GO jargon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants