-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There should be a way to exclude some GO rules when parsing a GAF file #544
Comments
Hey @valearna! I used to have this problem too. Somewhere in the ontobio/ontobio/io/assocparser.py Line 197 in 0ec3aa6
Let me know if you need more info! |
Thanks @dustine32! |
I find it surprising that filtering is the default behavior! GO team - remember ontobio is a general purpose framework that includes functionality for things like parsing GAFs. We of course want to use this general purpose framework to do things like implement specific rules such as filtering IBA from non-paint sources when run in a specific context. Even for our own internal GOC purposes this default behavior could come back and bite us. Let us say we rewrite the solr loadiing in python. If we load the outputs of the pipeline then if we do not remember the magic flag we will accidentally filter @valearna - thanks for the report we will prioritize fixing the behavior! |
To clarify maybe, the general/default case should not apply the rules, the optional/GO cases should be explicitly turned on. |
Thanks again for checking my PR on agr_loader @cmungall. I've set the attribute |
...and we should use a more meaningful flag name! |
To generate the Alliance gene descriptions, I'm loading GO obo file and the GAF files for the MODs with ontobio, but GO rule 26 is skipping IBA annotations. Is there a way to exclude a specific rule when parsing the GAFs? I'm happy to work on a PR if needed.
The text was updated successfully, but these errors were encountered: